Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure make uninstall removes default-config links. #496

Merged
merged 1 commit into from
May 25, 2021

Conversation

somiaj
Copy link
Collaborator

@somiaj somiaj commented May 24, 2021

Update make uninstall to remove the FvwmScript links from the default-config from $FVWM_DATADIR and remove both
FVWM_MODULEDIR and FVWM_DATADIR if empty.

Closes #422

Copy link
Member

@ThomasAdam ThomasAdam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @somiaj

Does this address #422 ? If so, can you expand your commit message so it addresses this?

@ThomasAdam ThomasAdam added the type:bug Something's broken! label May 25, 2021
@ThomasAdam ThomasAdam added this to the 1.0.3 milestone May 25, 2021
Update make uninstall to remove the FvwmScript links from the
default-config from $FVWM_DATADIR and remove both
FVWM_MODULEDIR and FVWM_DATADIR if empty. Closes #422
@ThomasAdam ThomasAdam merged commit be363b7 into master May 25, 2021
@ThomasAdam ThomasAdam deleted the js/uninstall-rm-links branch May 25, 2021 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something's broken!
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Some files/dirs not removed by make uninstall
2 participants