Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency on Perl4::CoreLibs::getcwd (fvwm3) #90

Merged
merged 1 commit into from
May 24, 2020
Merged

remove dependency on Perl4::CoreLibs::getcwd (fvwm3) #90

merged 1 commit into from
May 24, 2020

Conversation

slazav
Copy link
Contributor

@slazav slazav commented May 23, 2020

Cwd module is used instead of outdated getcwd.pl from Perl4::CoreLibs
see: https://metacpan.org/pod/Perl4::CoreLibs
To keep old behaviour "\n" is added to the output.

@ThomasAdam
Copy link
Member

Hi @slazav,

Thanks for this. It would be good if you could take a look at the minimum perl version we assert in configure.ac (5.8), and take steps to bump the minimum version we support to 5.20.x

Can you augment this patch series to look into this?

Thanks,
Thomas

@slazav
Copy link
Contributor Author

slazav commented May 24, 2020

It would be good if you could take a look at the minimum perl version we assert in configure.ac
(5.8), and take steps to bump the minimum version we support to 5.20.x

I'm not familiar with perl versions and do not quite understand what can be done here. In the configure.ac REQUIRED_PERL_VERSION=5.004, and Cwd::getcwd function exists in this version:
https://metacpan.org/pod/distribution/Module-CoreList-List/lib/Module/CoreList/List/5_004.pod
It looks like there is no need to increase it.

@ThomasAdam
Copy link
Member

Hi @slazav,

Well, there's things we can do...

  • Deprecate use fields
  • Remove subroutine prototypes
  • Use IPC::Run over backticks

But your patch is such a small step towards this. I'll apply it, but should you want to work on the above, let me know.

Kindly,
Thomas

@ThomasAdam ThomasAdam merged commit 938051b into fvwmorg:master May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants