Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish between source and destination of attack in attacks summary for cities with active honeypots #12

Open
katkad opened this issue Sep 10, 2013 · 5 comments · May be fixed by #13

Comments

@katkad
Copy link
Contributor

katkad commented Sep 10, 2013

hi,

when i have honeypots in Prague, and 2 attacks originate from Prague, I see 2 attacks from Czech Republic, but 4 attacks at red dot in Prague

@fw42
Copy link
Owner

fw42 commented Sep 10, 2013

I can't reproduce this (or don't understand what you mean). The code clearly only counts src events. Can you elaborate?

@katkad
Copy link
Contributor Author

katkad commented Sep 11, 2013

thanks for pointer. i'll look at the code

@katkad
Copy link
Contributor Author

katkad commented Sep 11, 2013

i think the problem is before the check if marker.type is "src" here

so if "src" and "dst" is Prague for example, @hits.marker[marker.id()][marker.eventName] is incremented twice when this one attack happens

@fw42
Copy link
Owner

fw42 commented Sep 11, 2013

Hm yeah I see what you mean. If the src marker and dst marker are at the exact same GPS location, then it will in fact double count. I can't just change the code to only count src events because we WANT to count the dst events too. Not sure what the best way to fix this would be, but I will think about it...

@katkad
Copy link
Contributor Author

katkad commented Sep 11, 2013

one possible solution is to store (and display) smt. like "dst info", and "src info" in GPS location where sensor is present. I don't know how you'd like that

@katkad katkad linked a pull request Sep 14, 2013 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants