Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test templates from DscResource.Template #108

Open
johlju opened this issue Jan 18, 2020 · 4 comments
Open

Move test templates from DscResource.Template #108

johlju opened this issue Jan 18, 2020 · 4 comments
Labels
enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community.

Comments

@johlju
Copy link
Collaborator

johlju commented Jan 18, 2020

We should move and update the test templates from here https://github.com/PowerShell/DscResource.Template/tree/master/Tests to this repo. For example the integration tests are missing in this repo.

@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Jan 19, 2020
@tmeckel
Copy link
Contributor

tmeckel commented Jan 25, 2020

@johlju to which folder inside Sampler shall the tests being moved? And regarding the Plaster template: what test from the DscResource.Template project shall be integrated in what mode inside the Plaster template. If any?

@johlju
Copy link
Collaborator Author

johlju commented Jan 25, 2020

We should make sure there are an appropriate unit test example and integration test example. The tests cannot be copied 1:1 from DscResource.Template as they need to align with the the CI pipeline too. But it’s on the header that differ. Please the the blog post https://dsccommunity.org/blog/convert-a-module-for-continuous-delivery/ and the section about changing header in unit, integration and common modules. The should be added to this module and the Plaster template. I think you have to look ok at the Plaster template Config file to see the location. On the phone now so not easy to see for me at the moment, but should be fairly easy to see there I think.

@gaelcolas
Copy link
Owner

Look here:
https://github.com/gaelcolas/Sampler/tree/master/Sampler/DSCResources/DSC_Folder

I started but haven't had time to finish.

@gaelcolas
Copy link
Owner

The example in DSC_ClassFolder is done for Pester v4, but needs updated for Pester 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community.
Projects
None yet
Development

No branches or pull requests

3 participants