Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-source-filesystem): fix createRemoteFileNode ts types #14086

Merged
merged 1 commit into from
May 16, 2019
Merged

fix(gatsby-source-filesystem): fix createRemoteFileNode ts types #14086

merged 1 commit into from
May 16, 2019

Conversation

antoinerousseau
Copy link
Contributor

@antoinerousseau antoinerousseau commented May 16, 2019

Description

createRemoteFileNode returns a Promise, but that's not what the TypeScript definitions file says.
This PR fixes the typings to indicate that it returns a Promise<FileSystemNode> instead of a FileSystemNode.

Related Issues

Fixes #13619

Related: #12348

@antoinerousseau
Copy link
Contributor Author

@wardpeet @KyleAMathews @orta can you have a quick look please?

Copy link
Contributor

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, yep

Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍🎉

@wardpeet wardpeet changed the title [gatsby-source-filesystem] fix createRemoteFileNode return type fix(gatsby-source-filesystem): fix createRemoteFileNode ts types May 16, 2019
@wardpeet wardpeet merged commit e47da77 into gatsbyjs:master May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants