Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the dependency on FreeImage optional #388

Open
mahiuchun opened this issue Jul 8, 2022 · 2 comments
Open

Make the dependency on FreeImage optional #388

mahiuchun opened this issue Jul 8, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@mahiuchun
Copy link
Contributor

Desired behavior

gz-common could be built without using FreeImage.

Alternatives considered

N/A

Implementation suggestion

Use https://github.com/nothings/stb/blob/master/stb_image.h for image loading.

Additional context

  • By not supporting less commonly used image formats, the attack surface of image loading is reduced.
  • FreeImage has an active SVN but they have not made a release since 2018.
@mahiuchun mahiuchun added the enhancement New feature or request label Jul 8, 2022
@wentasah
Copy link

This might be a good idea, as freeimage is known to contain many security vulnerabilities.

@mjcarroll
Copy link
Contributor

Yes, there has been a little bit of work attempting to replace the dependency with something like stb (#590) but I haven't had bandwidth to continue on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To do
Development

No branches or pull requests

3 participants