Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Ruby messages on versioned directory #27

Closed
osrf-migration opened this issue Apr 11, 2019 · 2 comments
Closed

Install Ruby messages on versioned directory #27

osrf-migration opened this issue Apr 11, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@osrf-migration
Copy link

Original report (archived issue) by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


Description

As of pull request #47 (released first into ign-msgs3), ruby messages are being installed at an unversioned directory, i.e. lib/ruby/ignition/cmdmsgs3.rb in my local install. It looks like the debs aren't installing them though. We noticed the problem while trying to create homebrew bottles for ign-msgs4, and the files are conflicting.

Steps to Reproduce

  1. Install ign-msgs3
  2. Install default

Expected behavior:

They should be installed side-by-side in versioned directories. I don't know how these files are being used, so I'm not sure what the appropriate directory structure would be. cc @nkoenig

Actual behavior:

The *_pb.rb messages are overwritten.

Versions

ign-msgs3 and default

Additional Information

For now, we're making the bottles for v3 and v4 conflict, so they're not side-by-side installable.

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


also reported in #24

@osrf-migration
Copy link
Author

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


  • changed state from "new" to "duplicate"

Duplicate of #24.

@osrf-migration osrf-migration added critical bug Something isn't working labels Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant