Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency License information missing #164

Open
NicoHood opened this issue Oct 25, 2020 · 2 comments · May be fixed by #167 or #170
Open

Dependency License information missing #164

NicoHood opened this issue Oct 25, 2020 · 2 comments · May be fixed by #167 or #170

Comments

@NicoHood
Copy link
Contributor

I think there are licenses missing in this repo:

Correct me, if I am wrong or if I missed a project.
@rhukster
Copy link
Member

Feel free to submit a PR that adds them.

@NicoHood NicoHood linked a pull request Oct 30, 2020 that will close this issue
Open
@NicoHood
Copy link
Contributor Author

NicoHood commented Oct 30, 2020 •
edited
Loading

I did a different approach:
I've removed the bricklayer dependency: #167

For Spectre:
I'd update to the latest version (just minor fixes) and add a license

For Line-Awesome:
I'd also update to the latest version, including font awesome compatibility and v4 + v5 support. I've done a lot of testing and also put a lot of work into beautifying the code structure (line awesome downloads are somehow incomplete if you checked the other issues about upgrading)

If that is okay, I will work on the PR about line-awesome.

@NicoHood NicoHood linked a pull request Oct 30, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rhukster @NicoHood