This repository has been archived by the owner on Apr 9, 2021. It is now read-only.
[MRG] Added Unit Tests for Preference, etc #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huangyz0918
changed the title
|
|
||
| @RunWith(RobolectricTestRunner.class) | ||
| @LooperMode(PAUSED) | ||
| public class HpReceiverActivityTest { |
There was a problem hiding this comment.
It would be awesome if we can add some cases to verify the form transfer, not necessary in this PR, we can do that in different but we should do that as well, we may have to take help of Mockito in that case to mock the sender's behaviour.
lakshyagupta21
approved these changes
Jul 23, 2019
lakshyagupta21
approved these changes
Jul 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #265
What has been done to verify that this works as intended?
I have tested the unite test locally, everything went well.
Why is this the best possible solution? Were any other approaches considered?
N/A
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
N/A
Before submitting this PR, please make sure you have:
./gradlew checkCodeand confirmed all checks still pass OR confirm CircleCI build passes