Fix outdated readme and remove outdated experimental comments #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1383 +/- ##
==========================================
- Coverage 90.76% 89.90% -0.86%
==========================================
Files 177 179 +2
Lines 5619 5758 +139
==========================================
+ Hits 5100 5177 +77
- Misses 519 581 +62
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 49a149b | 301.96 ms | 344.51 ms | 42.55 ms |
| ad69abc | 297.35 ms | 385.89 ms | 88.54 ms |
| 40680d3 | 323.55 ms | 390.29 ms | 66.73 ms |
| 90db9ff | 334.86 ms | 388.14 ms | 53.28 ms |
| eecbbca | 324.37 ms | 352.49 ms | 28.12 ms |
| 08a7b4f | 346.47 ms | 403.29 ms | 56.82 ms |
| 21845e2 | 345.08 ms | 382.82 ms | 37.74 ms |
| a7acb24 | 301.00 ms | 357.38 ms | 56.38 ms |
| a49594a | 282.27 ms | 344.84 ms | 62.57 ms |
| 521cfbf | 332.78 ms | 376.04 ms | 43.26 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 49a149b | 5.94 MiB | 6.92 MiB | 1001.54 KiB |
| ad69abc | 6.06 MiB | 7.09 MiB | 1.03 MiB |
| 40680d3 | 6.06 MiB | 7.03 MiB | 989.25 KiB |
| 90db9ff | 6.06 MiB | 7.10 MiB | 1.04 MiB |
| eecbbca | 5.94 MiB | 6.89 MiB | 975.78 KiB |
| 08a7b4f | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 21845e2 | 5.94 MiB | 6.92 MiB | 1003.77 KiB |
| a7acb24 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| a49594a | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 521cfbf | 5.94 MiB | 6.97 MiB | 1.03 MiB |
brustolin
approved these changes
Apr 6, 2023
|
Don't forget about Line 105 in 5bdfbc0 |
yep, I committed but got a:
Good catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
#skip-changelog
💡 Motivation and Context
Closes #1381
💚 How did you test it?
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps