Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mark session as errored in iOS #270

Merged
merged 3 commits into from
Jan 19, 2021
Merged

Conversation

philipphofmann
Copy link
Member

📜 Description

Update sentry-cocoa to 6.1.3, which contains the fix
getsentry/sentry-cocoa#906 for this issue.

💡 Motivation and Context

Fixes GH-268

💚 How did you test it?

With an emulator.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

Update sentry-cocoa to 6.1.3, that contains the fix
getsentry/sentry-cocoa#906 for this issue.

Fixes GH-268
@marandaneto
Copy link
Contributor

apparently, GH images don't have the previous NDK version installed :(

@philipphofmann
Copy link
Member Author

apparently, GH images don't have the previous NDK version installed :(

Can we update the NDK?

@philipphofmann philipphofmann merged commit b1566fe into main Jan 19, 2021
@philipphofmann philipphofmann deleted the fix/errored-sessions branch January 19, 2021 07:06
@marandaneto
Copy link
Contributor

apparently, GH images don't have the previous NDK version installed :(

Can we update the NDK?

I already did

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release Health sessions are not marked errored on iOS
2 participants