Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Remove Sentry.currentHub #490

Merged
merged 2 commits into from
Jun 8, 2021
Merged

Feat: Remove Sentry.currentHub #490

merged 2 commits into from
Jun 8, 2021

Conversation

ueman
Copy link
Collaborator

@ueman ueman commented Jun 7, 2021

๐Ÿ“œ Description

Removes Sentry.currentHub

๐Ÿ’ก Motivation and Context

Closes #405

๐Ÿ’š How did you test it?

Nothing to test because code removal

๐Ÿ“ Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

๐Ÿ”ฎ Next steps

@ueman ueman requested a review from marandaneto as a code owner June 7, 2021 16:32
CHANGELOG.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #490 (72f5d87) into main (5030464) will decrease coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #490      +/-   ##
==========================================
- Coverage   90.19%   89.92%   -0.28%     
==========================================
  Files          54       49       -5     
  Lines        1734     1568     -166     
==========================================
- Hits         1564     1410     -154     
+ Misses        170      158      -12     
Impacted Files Coverage ฮ”
dart/lib/src/sentry.dart 88.70% <รธ> (+2.77%) โฌ†๏ธ
dart/lib/src/sentry_options.dart 91.30% <รธ> (รธ)
dart/lib/src/version.dart 100.00% <รธ> (รธ)
dart/lib/src/sentry_stack_trace_factory.dart 98.07% <100.00%> (+0.03%) โฌ†๏ธ
flutter/lib/src/widgets_binding_observer.dart
flutter/lib/src/sentry_flutter_options.dart
flutter/lib/src/file_system_transport.dart
flutter/lib/src/sentry_flutter.dart
.../lib/src/navigation/sentry_navigator_observer.dart

Continue to review full report at Codecov.

Legend - Click here to learn more
ฮ” = absolute <relative> (impact), รธ = not affected, ? = missing data
Powered by Codecov. Last update cc6b2eb...72f5d87. Read the comment docs.

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ueman ueman merged commit 2bf8577 into main Jun 8, 2021
@ueman ueman deleted the feat/remove-currentHub branch June 8, 2021 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Sentry.currentHub in v6.0.0
3 participants