Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scripts to run flutter test and flutter analyze on all files before pushing. #822

Open
AliAkberAakash opened this issue Apr 6, 2022 · 3 comments

Comments

@AliAkberAakash
Copy link
Contributor

AliAkberAakash commented Apr 6, 2022

This feature is for repository maintenance.

Before pushing I run flutter test but often forget to run flutter analyze. Also doing this manually doing cd in each folder is a bit cumbersome. It would be a lot easier to just run a script and do this for all files. This would also decrease frequent pushes to PR's .

Also if there is a plan to do this, can I be assigned the task?

@marandaneto
Copy link
Contributor

There is already, do you mean this?
https://github.com/getsentry/sentry-dart/blob/main/dart/tool/presubmit.sh

@AliAkberAakash
Copy link
Contributor Author

This is for the dart module only? Or does this run for every module?

@marandaneto
Copy link
Contributor

This is for the dart module only? Or does this run for every module?

Indeed, it's not executed once and works for all modules, that could be improved.
You'd need to do it for each folder.
Another option is having a GH Action that executes and commits missing formats in the code on CI, so you don't need to bother about doing it locally, e.g. https://github.com/getsentry/sentry-java/pull/1963/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

4 participants