Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made cache.key span data field a list #3110

Merged
merged 9 commits into from
Jun 4, 2024

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented May 29, 2024

Make sure the cache.key span data field in cache spans is always an array, with one or more fields. (Compared to the description of the cache spans that is a comma separated string of the keys.)

See spec here: https://develop.sentry.dev/sdk/performance/modules/caches/

Fixes #3117

@antonpirker antonpirker marked this pull request as ready for review May 29, 2024 13:58
sentry_sdk/integrations/redis/utils.py Outdated Show resolved Hide resolved
sentry_sdk/integrations/redis/utils.py Outdated Show resolved Hide resolved
sentry_sdk/integrations/redis/utils.py Show resolved Hide resolved
sentry_sdk/integrations/redis/utils.py Show resolved Hide resolved
sentry_sdk/integrations/redis/utils.py Show resolved Hide resolved
@antonpirker antonpirker enabled auto-merge (squash) June 4, 2024 06:58
@antonpirker antonpirker merged commit 651c3b2 into master Jun 4, 2024
110 checks passed
@antonpirker antonpirker deleted the antonpirker/fix-caching-module-cache.key branch June 4, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnicodeDecodeError with certain Redis keys
2 participants