-
-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto save on tab removal #1457
Comments
What changes did you apply in SingleFile (related to this issue)? |
Sorry for the delay. I made changes in src/ui/bg/ui-menus.js to turn on MENU_ID_AUTO_SAVE_TAB to true. I also made changes in src/core/bg/config.js to enable autoSaveUnload: true. I think the issue was may be rebuilding the chromium zip file, because I was making the changes in the exploded directory directly and loading the extension through puppeteer. But these changes were being picked from lib, so rebuilding solved the issue. Now it has been working really well, which helped solve the problem of saving long and content rich pages through singlefile cli. But from time to time, autosave on page unload does not save the file. Here are the steps:
I think for some reason the save message is not coming through for some pages, in case they are heavy in content. I tried giving it time before I go back in that tab or before I close the browser, but it just does not produce a file. |
Thank you for the feedback. I'm glad to hear that you were able to find the cause the problem. I tried to reproduce the bug as described in the step 3 but I cannot reproduce it. Every time I do the test with www.apple.com/apple-vision-pro, the page is downloaded as expected after pressing the back button. Do you have other extensions installed? |
For questions, please create or update a thread here:
https://github.com/gildas-lormeau/SingleFile/discussions
Please ensure that you do not find an answer before reporting the issue:
Describe the bug
Any help would be greatly appreciated, thanks...
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: