Wrong matched route path in the context

[drsect0r]

• go version go1.12 linux/amd64
• gin commit 6e320c9
• Ubuntu inside Windows Subsystem for Linux

Description

We were pretty excited to perform code cleanup after #1826 was merged into master. We removed the git checkout and the #1390 patch present in our CI pipeline and worked based upon the latest master.

We noticed that one endpoint stopped working as expected and discovered that it was being misreported as a different route. As a test, we removed the erroneous route, but the endpoint in question still reported a wrong route path.

For now, we have restored the #1390 patch on top of commit e526148 and this resolved the issue.

[thinkerou]

@drsect0r can you post mini example in order to reproduce the issue? thanks!

[caihangui]

I think I had met the same problem @thinkerou

this is my code

func main() {
	r := gin.Default()
	r.GET("/ping", func(c *gin.Context) {

		fmt.Println("ping function 's c.FullPath() == ",c.FullPath())

		fmt.Println("c.FullPath() == \"/ping\" : ",c.FullPath() == "/ping")

		c.JSON(http.StatusOK, gin.H{})
	})

	r.GET("/pong", func(c *gin.Context) {

		fmt.Println("pong function 's c.FullPath() == ",c.FullPath())

		fmt.Println("c.FullPath() == \"/pong\" : ",c.FullPath() == "/pong")

		c.JSON(http.StatusOK, gin.H{})
	})

	r.Run()
}

but its result don't be expected

pong function 's c.FullPath() ==  /pong
c.FullPath() == "/pong" :  true
[GIN] 2019/06/14 - 14:52:58 | 200 |     199.792µs |             ::1 | GET      /pong
ping function 's c.FullPath() ==  /pong
c.FullPath() == "/ping" :  false
[GIN] 2019/06/14 - 14:53:07 | 200 |      42.793µs |             ::1 | GET      /ping

[bbiao]

My PR can fix your problems

=============
@caihangui the output will be like below if you apply my patch

ping function 's c.FullPath() == /ping
c.FullPath() == "/ping" : true
[GIN] 2019/06/14 - 15:23:21 | 200 | 95.29µs | 127.0.0.1 | GET /ping
pong function 's c.FullPath() == /pong
c.FullPath() == "/pong" : true
[GIN] 2019/06/14 - 15:23:27 | 200 | 44.114µs | 127.0.0.1 | GET /pong

#1919

[bbiao]

@drsect0r you can try this patch #1919

[drsect0r]

@bbiao Thank you for your patch! Will apply it tomorrow and report back.

Edit: Patch resolves the problem for us.

[thinkerou]

merged!