Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing power levels from deactivated users #446

Closed
tcpipuk opened this issue Jun 10, 2024 · 2 comments
Closed

Removing power levels from deactivated users #446

tcpipuk opened this issue Jun 10, 2024 · 2 comments
Labels
core-matrix enhancement New feature or request

Comments

@tcpipuk
Copy link
Sponsor Contributor

tcpipuk commented Jun 10, 2024

By design, Matrix doesn't automatically remove a user's power levels when they leave a room, and this is useful as an admin can rejoin a room to regain control without the room becoming "headless".

However, there is currently a risk that when a user is deactivated (e.g. when a server is being decommissioned) they'll remain in the power level list forever, so if a future server is created on the same domain, a malicious user can recreate the MXID and rejoin rooms with the same power level.

We know it's possible to go round changing these manually, but users rarely do, and many aren't familiar with The Matrix Way of storing power levels forever and assume it'll just work like other platforms that revert you to default on departure.

My ask: could we have a version of deactivation (a variant of the admin command, perhaps?) that takes care of other activities like sending a power level change for the user to all rooms they have non-default power levels in? It could even be a (non-default) config option to have this deactivation used automatically when someone deactivates themselves.

@girlbossceo
Copy link
Owner

This has been implemented in #571 which is available in our main branch and will be in the next tagged release.

This will be the default behaviour for account deactivations. I didn't think a config option was really that useful, but if manually deactivating a user through the admin room and you specify --no-leave-rooms, it will not drop their power level.

If someone finds a special use-case needed for not having this default behaviour, I can consider a (default enabled) config option.

Also, an MSC for this was made in MSC4165 which I'll notify that we have a server implementation for this now.

@tcpipuk
Copy link
Sponsor Contributor Author

tcpipuk commented Sep 16, 2024

Awesome, thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-matrix enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants