Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning if we are removing all users from CODEOWNERS #11

Open
zkoppert opened this issue Feb 1, 2024 · 6 comments
Open

Add a warning if we are removing all users from CODEOWNERS #11

zkoppert opened this issue Feb 1, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request keep

Comments

@zkoppert
Copy link
Member

zkoppert commented Feb 1, 2024

No description provided.

@zkoppert zkoppert added the enhancement New feature or request label Feb 1, 2024
Copy link

This issue is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Mar 13, 2024
@zkoppert zkoppert added keep and removed Stale labels Mar 14, 2024
@electriquo

This comment has been minimized.

@electriquo

This comment has been minimized.

@zkoppert
Copy link
Member Author

zkoppert commented Apr 2, 2024

How would folks like to see this warning? in the command line and dont create a pull request? or should we create the pull request and put the warning in the pull request description so folks dont merge through an empty CODEOWNERS?

@electriquo
Copy link

In my humble opinion, I believe we should draw inspiration from GitHub's stale-repos project. An organization is likely to run workflows like stale-repos, cleanowners, and others from a single repository, allowing the workflow to examine the entire organization.

For instance, the stale-repos action/workflow could maintain an issue with a list of stale repositories. Similarly, cleanowners could maintain an issue with lists of:

  • Repositories without a CODEOWNERS file
  • Repositories with an empty CODEOWNORS file
  • Links to open PRs created by cleanowners
  • Any other such lists...

By doing so, we can streamline our workflow and ensure that our organization's repositories are well-maintained and up-to-date.

@zkoppert
Copy link
Member Author

@electriquo I like that idea! I think I'll add a report and issue creation as well as printing a warning to the terminal during the workflow run.

@zkoppert zkoppert self-assigned this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request keep
Projects
None yet
Development

No branches or pull requests

2 participants