Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side-navigation menu items are unreadable when using a light theme with Firefox #25660

Closed
1 task done
jordojordo opened this issue May 22, 2023 · 3 comments
Closed
1 task done
Labels
content This issue or pull request belongs to the Docs Content team

Comments

@jordojordo
Copy link

Code of Conduct

What article on docs.github.com is affected?

I have noticed this issue all over the documentation, the side-navigation menu items appear to be using the incorrect colors while using a light theme provided by the User theme preferences. This issues happens with each light theme, and does not happen when using a dark theme.

Docs example - light theme - Firefox
git-docs-light-ff

Appearance preferences
git-appearance-light-ff

Docs example - dark theme - Firefox
git-docs-dark-ff

Note, this does not happen with Chrome.

Docs example - light theme - Chrome
git-docs-light-chrome

What changes are you suggesting?

The menu items should be readable when using a light theme regardless of browser.

Additional information

I tested this using Firefox 112.0.1 and 113.0.1 for archlinux, with private windows and no extensions installed.

ff-about

@jordojordo jordojordo added the content This issue or pull request belongs to the Docs Content team label May 22, 2023
@welcome
Copy link

welcome bot commented May 22, 2023

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 22, 2023
@jordojordo
Copy link
Author

jordojordo commented May 22, 2023

Closing this as there appears to be an internal discussion with this issue: #25235 (comment) - Sorry I didn't notice this before opening.

@cmwilson21
Copy link
Contributor

@jordojordo Thanks for the issue! We appreciate the leg work and finding the other comment about the internal issue 💖

Please take a look at our help wanted section to find open issues you can work on. We would love to have a PR from you sometime!

Thank you for your interest in improving GitHub Docs! ✨

@cmwilson21 cmwilson21 removed the triage Do not begin working on this issue until triaged by the team label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

No branches or pull requests

2 participants