-
Notifications
You must be signed in to change notification settings - Fork 59.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contradicting information about port mappings in service containers #34459
Comments
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
@hsnabszhdn Thank you for raising this issue! I'll get this triaged for review ✨ Our team will provide feedback regarding the best next steps for this issue - thanks for your patience! 💛 |
Thanks for opening an issue! We've triaged this issue for technical review by a subject matter expert 👀 |
This is a gentle bump for the docs team that this issue is waiting for technical review. |
@hsnabszhdn Thank you so much for your patience while our SME team reviewed!
Our SME team confirms you are correct 💛 I've added the |
Code of Conduct
What article on docs.github.com is affected?
What part(s) of the article would you like to see updated?
In both pages linked about, it says that if you don't specify the port, it maps the host port to a randomly chosen port on the container:
About service containers / Mapping Docker host and service container ports
I think, it's the other way around: "Map a randomly chosen port on the Docker host to UDP port 8080 in the container"
Workflow syntax for GitHub Actions /
jobs.<job_id>.services
/ Example: Using localhostI think, it should be: "When you specify the container port but not the Docker host port, the container port is randomly assigned to a free port."
Additional information
In the following page, I think the correct statement is used:
Accessing contextual information about workflow runs /
job
context / Example usage of the job contextThe text was updated successfully, but these errors were encountered: