Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distributionManagement isn't really needed in the pom.xml file #34775

Open
1 task done
Tracked by #34807
sixcorners opened this issue Sep 29, 2024 · 6 comments
Open
1 task done
Tracked by #34807

distributionManagement isn't really needed in the pom.xml file #34775

sixcorners opened this issue Sep 29, 2024 · 6 comments
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team needs SME This proposal needs review from a subject matter expert waiting for review Issue/PR is waiting for a writer's review

Comments

@sixcorners
Copy link

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/use-cases-and-examples/publishing-packages/publishing-java-packages-with-maven

What part(s) of the article would you like to see updated?

Instead of messing with the distributionManagement xml element in the pom.xml file you could just change the mvn command to mvn --batch-mode -DaltDeploymentRepository=github::https://maven.pkg.github.com/${{ github.repository }} deploy. It's way easier than copy/paste/editing the fragment of xml and integrating it into some kind of parent pom and keeping these ids in sync.
The user property is documented here: https://maven.apache.org/plugins/maven-deploy-plugin/deploy-mojo.html#altDeploymentRepository

I guess you could keep the distributionManagement stuff for people who prefer to do it that way.

Additional information

No response

@sixcorners sixcorners added the content This issue or pull request belongs to the Docs Content team label Sep 29, 2024
Copy link

welcome bot commented Sep 29, 2024

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 29, 2024
@nguyenalex836
Copy link
Contributor

@sixcorners Thank you for raising this issue! I'll get this triaged for review ✨ Our team will provide feedback regarding the best next steps for this issue - thanks for your patience! 💛

@nguyenalex836 nguyenalex836 added actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review needs SME This proposal needs review from a subject matter expert and removed triage Do not begin working on this issue until triaged by the team labels Sep 30, 2024
Copy link
Contributor

Thanks for opening an issue! We've triaged this issue for technical review by a subject matter expert 👀

@sixcorners
Copy link
Author

I bet you could also put the altDeploymentRepository into the generated settings.xml file as a property in an activated by default profile. Not sure though

@Mohelgohary70

This comment was marked as spam.

@Mohelgohary70

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team needs SME This proposal needs review from a subject matter expert waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

No branches or pull requests

3 participants