Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated instructions on "Allowing changes to a pull request branch created from a fork" on how to allow changes #7890

Merged
merged 2 commits into from
Jul 2, 2021
Merged

Updated instructions on "Allowing changes to a pull request branch created from a fork" on how to allow changes #7890

merged 2 commits into from
Jul 2, 2021

Conversation

ramyaparimi
Copy link
Contributor

Updated the information to match the title of the instructions, which is to allow the changes for the docs: https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

Why:

Closes #6880

What's being changed:

Updated Step 4 to allow changes.

image

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Updated the info to match the title of the instructions
@welcome
Copy link

welcome bot commented Jul 2, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 2, 2021
@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jul 2, 2021
@github github deleted a comment Jul 2, 2021
@janiceilene
Copy link
Contributor

@ramyaparimi Thanks so much for opening a PR! I'll get this triaged for review ⚡

Copy link
Contributor

@janiceilene janiceilene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ramyaparimi Thanks so much for opening a PR with this fix! This change looks great 🌟 I'm going to update the branch and merge this in once tests are passing 🍏

@janiceilene janiceilene added the ready to merge This pull request is ready to merge label Jul 2, 2021
@github-actions github-actions bot removed the waiting for review Issue/PR is waiting for a writer's review label Jul 2, 2021
@janiceilene janiceilene merged commit e10a3e4 into github:main Jul 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge
Projects
None yet
2 participants