Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gp cli] gp command to print/show workspace class #10572

Closed
csweichel opened this issue Jun 10, 2022 · 4 comments · Fixed by #12338
Closed

[gp cli] gp command to print/show workspace class #10572

csweichel opened this issue Jun 10, 2022 · 4 comments · Fixed by #12338

Comments

@csweichel
Copy link
Contributor

Is your feature request related to a problem? Please describe

We recently added an environment variable which carries the name of the workspace class a workspace is running on.

Describe the behaviour you'd like

Environment variables are not always stable - and we are trying to educate folks to not rely on them. Instead, we should plug this into the supervisor info endpoint, and add a gp command to access it.

@loujaybee loujaybee changed the title [gp cli] Add means to print workspace class [gp cli] gp command to print/show workspace class Aug 16, 2022
@loujaybee loujaybee changed the title [gp cli] gp command to print/show workspace class [gp cli] gp command to print/show workspace class Aug 16, 2022
@akosyakov
Copy link
Member

I think the logical place will be gp top. It should show workspace class, its configuration for CPU and MEMORY, usage, and provide hints to upgrade if necessary.

To consume programatically we can provide an option like gp top --json.

@mustard-mh
Copy link
Contributor

mustard-mh commented Aug 26, 2022

x-posting suggestions of gp top here #12338 (comment) #12338 (review)

Maybe another gp command like gp workspace class is worth built?

cc @filiptronicek @andreafalzetti

Another reason to add class description in gp top is, sometimes the limit of resources in gp top is not align to the workspace's limit but limit in a time window

@akosyakov
Copy link
Member

akosyakov commented Aug 26, 2022

I think we maybe will need to have another command to get different info about workspace, that people can rely on it instead of env var as now. But then it should be rather one command like gp info (workspaceId|instanceId|workspaceClass|...)? I think there is already an issue to deprecate evn var and we could do it as a part later.

@loujaybee
Copy link
Member

loujaybee commented Nov 1, 2022

This is now shipped!

https://www.gitpod.io/changelog#easily-find-information-about-your-workspace-with-gp-info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants