Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test "test_aes_gcm_encrypt_decrypt" in test_crypto.c? #39

Closed
hartwork opened this issue Jan 29, 2022 · 1 comment
Closed

Flaky test "test_aes_gcm_encrypt_decrypt" in test_crypto.c? #39

hartwork opened this issue Jan 29, 2022 · 1 comment

Comments

@hartwork
Copy link
Contributor

It seems like one of the tests is flaky, at least on Windows:

 [ RUN      ] test_aes_gcm_encrypt_decrypt
[  ERROR   ] --- 0x0 != 0xffffffffffffd8dc
[   LINE   ] --- D:/a/libomemo/libomemo/test/test_crypto.c:79: error: Failure!

Would be cool to understand and become stable.

@hartwork hartwork changed the title Flaky test "test_aes_gcm_encrypt_decrypt"? Flaky test "test_aes_gcm_encrypt_decrypt" in test_crypto.c? Jan 29, 2022
@hartwork
Copy link
Contributor Author

hartwork commented Feb 7, 2022

It turns out that line…

ciphertext_p[0] = 0x00;

…has the underlying assumption that the previous value is not already 0. But it can be, and then the test fails.

@gkdr gkdr closed this as completed in cc8bf3a Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant