Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tarball with no top-level directory #94

Closed
mia-0 opened this issue Apr 21, 2018 · 3 comments
Closed

Release tarball with no top-level directory #94

mia-0 opened this issue Apr 21, 2018 · 3 comments

Comments

@mia-0
Copy link

mia-0 commented Apr 21, 2018

Release tarballs should have a top-level directory named lurch-$version. This is expected by most packaging tools (and users generally don’t want the working directory littered with stuff when running tar -xf).

@mia-0
Copy link
Author

mia-0 commented Apr 21, 2018

Also, consider signing the source releases (and git commits) with GPG.

@gkdr
Copy link
Owner

gkdr commented Apr 28, 2018

and users generally don’t want the working directory littered with stuff when running tar -xf

That does sound convincing, I hate that and I didn't pay attention I guess.

I'm not sure if I'd break some of the community repo builds if I change it now though, but if you can show me which packaging tools say they expect it that way I'd have a strong case to change it.

@mia-0
Copy link
Author

mia-0 commented Apr 29, 2018

There are options to work around that of course, but for example the RPM %setup macro expects a single top-level directory by default. I imagine it is similar for Debian, as the vast majority of source code is distributed that way.

You’re also not very likely to break many community packages that way (and if so, it’s a trivial fix), as any distro worth its salt keeps a pristine copy of the sources instead of relying on GitHub and SourceForge to be around with unmodified tarballs.

@gkdr gkdr closed this as completed in eff5b0b Dec 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants