Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"experiments = python3" fails with git cinnabar fetch {URL} {REV} #272

Closed
arai-a opened this issue Apr 6, 2021 · 0 comments · Fixed by #273
Closed

"experiments = python3" fails with git cinnabar fetch {URL} {REV} #272

arai-a opened this issue Apr 6, 2021 · 0 comments · Fixed by #273

Comments

@arai-a
Copy link
Contributor

arai-a commented Apr 6, 2021

steps to reproduce:

  • run git cinnabar fetch hg::https://hg.mozilla.org/try 56585caa08bfe07f47684e85ce09e45de51fc72a on mozilla-unified checkout with git-cinnabar.

result:

Traceback (most recent call last):
  File "~/.mozbuild/git-cinnabar/cinnabar/util.py", line 999, in run
    retcode = func(args)
  File "~/.mozbuild/git-cinnabar/cinnabar/cmd/fetch.py", line 46, in fetch
    full_revs.append(rev.decode('ascii'))
AttributeError: 'str' object has no attribute 'decode'

git-cinnabar/cinnabar/cmd/fetch.py

Line 46 in 654fcf2

full_revs.append(rev.decode('ascii'))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move str.decode to hexlify in order to avoid extra decode on full sha1 arai-a/git-cinnabar
1 participant
@arai-a