From e24338b711b765deaff57ba1f1535b5707c0d77d Mon Sep 17 00:00:00 2001 From: Jonathan Arnett Date: Tue, 24 May 2022 14:37:41 -0400 Subject: [PATCH 1/2] Change constructor tracking to not use type --- queries/tags.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/queries/tags.scm b/queries/tags.scm index 3c26dfa..cfca227 100644 --- a/queries/tags.scm +++ b/queries/tags.scm @@ -32,10 +32,10 @@ (type_definition (data_constructors (data_constructor - name: (constructor_name) @name))) @definition.type + name: (constructor_name) @name))) @definition.constructor (external_type (type_name name: (type_identifier) @name)) @definition.type (type_identifier) @name @reference.type -(constructor_name) @name @reference.type +(constructor_name) @name @reference.constructor From bec3bdbf9dbbd40cc7ab93a899fd9541ef8c7563 Mon Sep 17 00:00:00 2001 From: Jonathan Arnett Date: Tue, 24 May 2022 14:45:47 -0400 Subject: [PATCH 2/2] Update tests --- test/tags/frame.gleam | 6 +++--- test/tags/functions.gleam | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/test/tags/frame.gleam b/test/tags/frame.gleam index 4e157f3..e6fad70 100644 --- a/test/tags/frame.gleam +++ b/test/tags/frame.gleam @@ -9,14 +9,14 @@ import gleam/bit_builder pub type FrameData { // ^ definition.type Text(String) - // <- definition.type + // <- definition.constructor // ^ reference.type Binary(BitString) Continuation(BitString) Ping(BitString) Pong(BitString) Close(code: Option(Int), reason: Option(String)) - // <- definition.type + // <- definition.constructor // ^ reference.type // ^ reference.type // ^ reference.type @@ -42,7 +42,7 @@ fn encode_frame(frame: Frame) -> bit_builder.BitBuilder { let opcode = case frame.data { Continuation(_) -> <<0x0:size(1)>> - // <- reference.type + // <- reference.constructor Text(_) -> <<0x1:size(1)>> Binary(_) -> <<0x2:size(1)>> // 0x3-7 reserved for future non-control frames diff --git a/test/tags/functions.gleam b/test/tags/functions.gleam index 56a35ff..dc1cf0d 100644 --- a/test/tags/functions.gleam +++ b/test/tags/functions.gleam @@ -1,6 +1,6 @@ fn record_with_fun_field(record) { let foo = Bar(baz: fn(x) { x + 1 }) - // ^ reference.type + // ^ reference.constructor foo.baz(41) record.foobar("hello")