Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching up the watching pattern and filesystem implementation #325

Open
3 tasks
glenn2223 opened this issue Sep 27, 2023 · 0 comments
Open
3 tasks

Switching up the watching pattern and filesystem implementation #325

glenn2223 opened this issue Sep 27, 2023 · 0 comments
Labels
enhancement New feature or request
Milestone
v7

Comments

@glenn2223
Copy link
Owner

glenn2223 commented Sep 27, 2023 •
edited
Loading

Issues

  1. Using VS Code's onDidSaveTextDocument event isn't enough to identify external changes (like those from the dev tools).
  2. fdir is a fantastic tool, but there have been a few issues with shadow files and network drives/files

Proposal

Rather than using VS Code's onDidSaveTextDocument event, we will instead implement their file watcher

We will move away fdir and use VS Code's fs manager

TODO

  • Move to VS Code's own fs manager
  • Remove the dependency on fdir
  • Move to file watching rather than onDidChange event

Should resolve/close
@glenn2223 glenn2223 added the enhancement New feature or request label Sep 27, 2023
@glenn2223 glenn2223 added this to the v7 milestone Sep 27, 2023
@glenn2223 glenn2223 mentioned this issue Nov 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v7
Development

No branches or pull requests
1 participant
@glenn2223