From c96f3ce58360d072b753327e66c90dad635322b5 Mon Sep 17 00:00:00 2001
From: Bo-Yi Wu <appleboy.tw@gmail.com>
Date: Sat, 1 Jan 2022 15:40:22 +0800
Subject: [PATCH] chore(lint): enable revive lint.

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
---
 .golangci.yml | 29 +++++++++++++++++++++++++++++
 .revive.toml  | 27 ---------------------------
 2 files changed, 29 insertions(+), 27 deletions(-)
 delete mode 100644 .revive.toml

diff --git a/.golangci.yml b/.golangci.yml
index 9e64d71b594a..235bb76715bd 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -16,6 +16,7 @@ linters:
     - gocritic
     - bidichk
     - ineffassign
+    - revive
   enable-all: false
   disable-all: true
   fast: false
@@ -28,6 +29,34 @@ linters-settings:
     disabled-checks:
       - ifElseChain
       - singleCaseSwitch # Every time this occurred in the code, there  was no other way.
+  revive:
+    ignore-generated-header: false
+    severity: warning
+    confidence: 0.8
+    errorCode: 1
+    warningCode: 1
+    rules:
+      - name: blank-imports
+      - name: context-as-argument
+      - name: context-keys-type
+      - name: dot-imports
+      - name: error-return
+      - name: error-strings
+      - name: error-naming
+      - name: exported
+      - name: if-return
+      - name: increment-decrement
+      - name: var-naming
+      - name: var-declaration
+      - name: package-comments
+      - name: range
+      - name: receiver-naming
+      - name: time-naming
+      - name: unexported-return
+      - name: indent-error-flow
+      - name: errorf
+      - name: duplicated-imports
+      - name: modifies-value-receiver
 
 issues:
   exclude-rules:
diff --git a/.revive.toml b/.revive.toml
deleted file mode 100644
index 54f075f84f51..000000000000
--- a/.revive.toml
+++ /dev/null
@@ -1,27 +0,0 @@
-ignoreGeneratedHeader = false
-severity = "warning"
-confidence = 0.8
-errorCode = 1
-warningCode = 1
-
-[rule.blank-imports]
-[rule.context-as-argument]
-[rule.context-keys-type]
-[rule.dot-imports]
-[rule.error-return]
-[rule.error-strings]
-[rule.error-naming]
-[rule.exported]
-[rule.if-return]
-[rule.increment-decrement]
-[rule.var-naming]
-[rule.var-declaration]
-[rule.package-comments]
-[rule.range]
-[rule.receiver-naming]
-[rule.time-naming]
-[rule.unexported-return]
-[rule.indent-error-flow]
-[rule.errorf]
-[rule.duplicated-imports]
-[rule.modifies-value-receiver]