Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to handle incorrect ROOT_URL for gitea.com #19407

Closed
wxiaoguang opened this issue Apr 15, 2022 · 1 comment
Closed

How to handle incorrect ROOT_URL for gitea.com #19407

wxiaoguang opened this issue Apr 15, 2022 · 1 comment

Comments

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Apr 15, 2022

After the PR (background #19345)

Now if users visit www.gitea.com, they will see the prompt.

I think the prompt is correct at the moment.

A real case: if users log into www.gitea.com, then many URLs are pointing to gitea.com, then if they try to visit it, they are still not logged-in on gitea.com because the cookie is not shared between these two domains.

This problem becomes more serious because some forms and ajax requests are using absolute URL to gitea.com, users may lose their work if they try to submit request to gitea.com from www.gitea.com.

And that's one of the reasons why some users complain that their work are lost, see screenshot 2, the URL in form is absolute.

Then the question is: how to continue? IMO the proper way is to make www.gitea.com redirect users to gitea.com at the moment.

Screenshot 1, incorrect ROOT_URL

image

Screenshot 2, the absolute URL in form

image

@lunny
Copy link
Member

lunny commented Apr 15, 2022

We always need to redirect www.gitea.com to gitea.com

@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants