Extra blank line shown at end of files

[ghost]

Description

Any file that ends in a single \n (so no visible trailing newline in text editors) seems to have an extra blank numbered line shown when viewing it from Gitea on web. I'm posting this as a new issue as #4050 is closed and locked but it appears to have regressed.

I can't seem to reproduce this on try.gitea.io so perhaps it's been fixed in dev already, but on a quick search I haven't found any recent commits or issues relating to this.

Gitea Version

1.17.2

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No EOL:

Single EOL\n:

Double EOL\n\n:

Git Version

2.31.0

Operating System

Debian 11

How are you running Gitea?

Precompiled build, systemd service

Database

MySQL

[wxiaoguang]

Can you try it with 1.18 (https://try.gitea.io)?

I think the problem has a clear solution now (but not in 1.17, due to some long argument before 1.17's freezing)

• Rework file highlight rendering and fix yaml copy-paste #19967
• Remove final newline from rendered code #18076 (comment)

[ghost]

Yeah seems fine there, didn't spot that this was explicitly addressed recently.