-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
possible misuse of unsafe.Pointer in gasyncresult.go #74
Comments
This is the line in question: https://github.com/go-gst/go-glib/blob/main/glib/gasyncresult.go#L86 |
The function in question is the following: // IsTagged is a wrapper around g_async_result_is_tagged
func (v *AsyncResult) IsTagged(sourceTag uintptr) bool {
c := C.g_async_result_is_tagged(v.native(), C.gpointer(sourceTag))
return gobool(c)
} The linter is complaining about a cast from the Related to #62 |
@sirzooro are you actively using the But the linters are correct, normally how it is now is already broken, these types of casts can lead to really fun to debug segmentation faults. That is why this wont be a major release in terms of semver |
No, feel free to change it. |
FYI this issue was autoclosed and is only actually completed with the merger of #75 |
I tried to add these bindings to my app, and during compilation I got following error:
I was able to silence this by adding
// nolint:unsafeptr
comment to this line. Please fix this or add this comment if this is a false positive.The text was updated successfully, but these errors were encountered: