Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: not found page can't be hit when authenticated #973

Open
wass3rw3rk opened this issue Apr 25, 2024 · 3 comments
Open

ui: not found page can't be hit when authenticated #973

wass3rw3rk opened this issue Apr 25, 2024 · 3 comments
Labels
bug Indicates a bug

Comments

@wass3rw3rk
Copy link
Member

Description

currently, the not found page can be hit when unauthenticated, once you are authenticated it can not - instead you are always redirected to "/".

Value

Useful Information

affects currently unreleased UI

  1. What is the output of vela --version?
    v0.25 (unreleased)
  1. What operating system is being used?
  1. Any other important details?
@wass3rw3rk wass3rw3rk added the bug Indicates a bug label Apr 25, 2024
@plyr4
Copy link
Contributor

plyr4 commented Sep 26, 2024

was looking into this and would love to build out a better 404 experience but im not sure what it looks like.

in a perfect world, what is the not found page when you are authenticated and have dynamic routes for vela.com/<org>/<repo> ?

@plyr4
Copy link
Contributor

plyr4 commented Sep 26, 2024

meaning, if i'm authenticated and i visit vela.com/garbage, vela.com/404, vela.com/not-found, or even vela.com/doesnt/exist
what should i see?

btw visiting vela.com/a/b/c/d should definitely go to a 404/not-found page but right now it just sends you to /.

so dont get me wrong theres definitely a low-hanging bug here regardless but i'd love to expand this into a better "page not found" experience overall if its possible

@wass3r
Copy link
Collaborator

wass3r commented Sep 27, 2024

yes, for sure. we can get creative. i know we talked about vela.com/<org>/<repo> before. i imagine something like "looks like this repo is not setup yet. do you want to try and enable it?" kind of messaging.

any org level page that doesn't have any repos enabled, probably something in a similar vein. maybe prompt if the user wants to enable a repo within that org? perhaps, offer the ability to browse repos filtered to that org that they have access to?

so, i think 404/not found perhaps best adjusts to each scenario, but there should be a generic one that's just, umm.. a 404-themed mini-game and you have to beat it to get back to the home/overview page? :D

i think i would scope this specific story to just deal with this "bug" and have separate issues for for some of the scenarios mentioned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates a bug
Projects
None yet
Development

No branches or pull requests

3 participants