Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User Agent update and Edge Browser UA addition #762

Closed
samirsss opened this issue Apr 7, 2023 · 3 comments · Fixed by #765
Closed

User Agent update and Edge Browser UA addition #762

samirsss opened this issue Apr 7, 2023 · 3 comments · Fixed by #765

Comments

@samirsss
Copy link

samirsss commented Apr 7, 2023

We have the Chrome, Firefox and Opera UA which are older versions from 2021 which need to be updated and also the newer Edge can be used for a user agent.

Could these be updated/added to the latest version of colly?
@samirsss
Copy link
Author

bump please

@samirsss samirsss mentioned this issue Apr 21, 2023
Merged
guessi added a commit to guessi/colly that referenced this issue Apr 22, 2023
@guessi
Update User-Agent strings for Firefox/Opera/Chrome/Edge
9fd6d6e 
- Removed Firefox version earlier than Jun 1, 2022
- Removed Google Chrome version earlier than Jun 1, 2022
- Removed Microsoft Edge version earlier than Jun 1, 2022
- Removed Opera version earlier than Jan 1, 2023
- Updated Mac OS version strings (10.2.x ~ 13.3.x)
- Extended support for Android 12/13

Fixes: gocolly#762
@guessi guessi mentioned this issue Apr 22, 2023
Merged
guessi added a commit to guessi/colly that referenced this issue Apr 22, 2023
@guessi
Update User-Agent strings for Firefox/Opera/Chrome/Edge
75c67a6 
- Removed Firefox version earlier than Jun 1, 2022
- Removed Google Chrome version earlier than Jun 1, 2022
- Removed Microsoft Edge version earlier than Jun 1, 2022
- Removed Opera version earlier than Jan 1, 2023
- Updated Mac OS version strings (10.2.x ~ 13.3.x)
- Extended support for Android 12/13

Fixes: gocolly#762
@guessi
Copy link
Contributor

guessi commented Apr 22, 2023

@samirsss I've update #765 for addressing this issue as you pin me at #605, but I'm not maintainer of the package. So you will need to wait for maintainer's review so that it could get merged.

@samirsss
Copy link
Author

samirsss commented May 2, 2023

@guessi - I understand it and really appreciate you doing this PR. Hopefully @asciimoo can review and approve the PR. I gave it a run and it looks good.

@WGH- WGH- closed this as completed in #765 May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update User-Agent strings for 2023 guessi/colly
2 participants
@guessi @samirsss