Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod file should be in upper folder #10251

Closed
bitsf opened this issue Dec 13, 2019 · 3 comments
Closed

go.mod file should be in upper folder #10251

bitsf opened this issue Dec 13, 2019 · 3 comments

Comments

@bitsf
Copy link
Contributor

bitsf commented Dec 13, 2019

currently file go.mod is in src folder, which is not standard, it should be in root folder, or when other project import harbor project, it also need add src in module path
vendor folder also need move to root folder
cmd entrance should be moved out too
other things like web and tools also have their suggested folder name

a golang reference layout is https://github.com/golang-standards/project-layout

@reasonerjt
Copy link
Contributor

I see this is a problem way more complicated than moving the content in src/ and go.mod to the root.

We probably should first make sure the paths within src/ have a better organization inside src/ and sort out the folders out of src/ according to a best practice, and then, move everything in src/ to root.

@github-actions
Copy link

github-actions bot commented Jul 7, 2022

This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days.

@github-actions github-actions bot added the Stale label Jul 7, 2022
@github-actions
Copy link

github-actions bot commented Aug 7, 2022

This issue was closed because it has been stalled for 30 days with no activity. If this issue is still relevant, please re-open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants