Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove src/vendor #18346

Closed
reasonerjt opened this issue Mar 14, 2023 · 3 comments · Fixed by #19508
Closed

Remove src/vendor #18346

reasonerjt opened this issue Mar 14, 2023 · 3 comments · Fixed by #19508

Comments

@reasonerjt
Copy link
Contributor

We are vendoring the dependencies of Harbor in ./src/vendor.
Currently, on main branch ./src/vendor is taking up 59M and ./src is taking 75M, i.e. the vendor folder is using ~90% of the size of all source code. In addition, there's a potential risk of inconsistency that someone may forget vendoring the dependency after updating go.mod.

Therefore, I wanna suggest we stop vendoring the dependencies and use go.mod as single source of truth.

The only negative impact is that it may take longer if we compile the code in container, in that case, we should use a local goproxy to accelerate downloading the moduls.

@github-actions
Copy link

This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days.

@wy65701436
Copy link
Contributor

move it to v2.10

@wy65701436 wy65701436 assigned reasonerjt and unassigned wy65701436 and MinerYang Aug 9, 2023
@reasonerjt reasonerjt added candidate/2.10.0 and removed needs/triage triage issue before assigning labels Aug 9, 2023
@github-actions
Copy link

github-actions bot commented Oct 8, 2023

This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants