-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove src/vendor #18346
Labels
Comments
This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days. |
move it to v2.10 |
reasonerjt
added
candidate/2.10.0
and removed
needs/triage
triage issue before assigning
labels
Aug 9, 2023
This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We are vendoring the dependencies of Harbor in
./src/vendor
.Currently, on
main
branch./src/vendor
is taking up 59M and./src
is taking 75M, i.e. the vendor folder is using ~90% of the size of all source code. In addition, there's a potential risk of inconsistency that someone may forget vendoring the dependency after updatinggo.mod
.Therefore, I wanna suggest we stop vendoring the dependencies and use
go.mod
as single source of truth.The only negative impact is that it may take longer if we compile the code in container, in that case, we should use a local goproxy to accelerate downloading the moduls.
The text was updated successfully, but these errors were encountered: