From d6f4f33f50be07493a53ad0e82f7a47603371e1e Mon Sep 17 00:00:00 2001 From: OrlinVasilev Date: Mon, 20 Mar 2023 16:20:59 +0200 Subject: [PATCH 1/7] Update proposal process wthh steps and board Signed-off-by: OrlinVasilev --- CONTRIBUTING.md | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 74a0f0eadb0..adfabc77a53 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -364,11 +364,22 @@ The main location for the documentation is the [website repository](https://gith Documents are written with Markdown. See [Writing on GitHub](https://help.github.com/categories/writing-on-github/) for more details. -## Design new features - -You can propose new designs for existing Harbor features. You can also design entirely new features, Please submit a proposal in GitHub.(https://github.com/goharbor/community/tree/master/proposals). Harbor maintainers will review this proposal as soon as possible. This is necessary to ensure the overall architecture is consistent and to avoid duplicated work in the roadmap. - -[community-meetings]: https://github.com/goharbor/community/blob/master/MEETING_SCHEDULE.md +## Propose and design new features + +You can propose new designs for existing Harbor features or you can also design entirely new features by following few simple step process: +- Check the current proposals if your feature is not requested or worked on already. Check both [Issues](https://github.com/goharbor/harbor/issues) and [PRs](https://github.com/goharbor/harbor/pulls) in the main Harbor repository also in the [Community repository](https://github.com/goharbor/community). +- Submit(open PR) the new proposal at [community/proposals/new](https://github.com/goharbor/community/tree/main/proposals/new) using the already existing [template](https://github.com/goharbor/community/blob/main/proposals/TEMPLATE.md) +- Once submitted it must be labeled as "kind/proposal" - check examples [here](https://github.com/goharbor/community/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+label%3Akind%2Fproposal) +- Will be automatically added to the [Community Proposals Board](https://github.com/orgs/goharbor/projects/4?query=is%3Aopen+sort%3Aupdated-desc) +- Once in on the board it must be added to a [Community Meeting agenda](https://github.com/goharbor/community/wiki/Harbor-Community-Meetings) to be presented to maintainers and contributors.(also moved to the next phase on the board "Community Meeting Discussion") +- Next is to be reviewed and modified by maintainers and other contributors maintainers in a timely manner. This is necessary to ensure the overall architecture is consistent and to avoid duplicated work in the [RoadMap](). +- When reviewed and approved it can be implemented either by the original submitter which we highly encourage, as the project is community driven. That can happen via opening PRs in the respective repositories with all the necessary code and test changes! +- Once implemented the PRs must be reviewed by maintainers and contributors prior merging following the currently enabled practices and methods. +- After merging the new PRs the proposal must be moved to [community/proposals](https://github.com/goharbor/community/tree/main/proposals) and marked as Done! +- Congratulations you have made Harbor even better! Thank you! + + +[community-meetings]: https://github.com/goharbor/community/blob/main/MEETING_SCHEDULE.md [past-meetings]: https://www.youtube.com/playlist?list=PLgInP-D86bCwTC0DYAa1pgupsQIAWPomv [users-slack]: https://cloud-native.slack.com/archives/CC1E09J6S [dev-slack]: https://cloud-native.slack.com/archives/CC1E0J0MC From 7676681a94360dd0db0e4e9accb2cfc53805701b Mon Sep 17 00:00:00 2001 From: OrlinVasilev Date: Mon, 20 Mar 2023 16:20:59 +0200 Subject: [PATCH 2/7] Update proposal process wthh steps and board Signed-off-by: OrlinVasilev --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index adfabc77a53..d9627111104 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -372,7 +372,7 @@ You can propose new designs for existing Harbor features or you can also design - Once submitted it must be labeled as "kind/proposal" - check examples [here](https://github.com/goharbor/community/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+label%3Akind%2Fproposal) - Will be automatically added to the [Community Proposals Board](https://github.com/orgs/goharbor/projects/4?query=is%3Aopen+sort%3Aupdated-desc) - Once in on the board it must be added to a [Community Meeting agenda](https://github.com/goharbor/community/wiki/Harbor-Community-Meetings) to be presented to maintainers and contributors.(also moved to the next phase on the board "Community Meeting Discussion") -- Next is to be reviewed and modified by maintainers and other contributors maintainers in a timely manner. This is necessary to ensure the overall architecture is consistent and to avoid duplicated work in the [RoadMap](). +- Next is to be reviewed and modified by maintainers and other contributors maintainers in a timely manner. This is necessary to ensure the overall architecture is consistent and to avoid duplicated work in the [Roadmap](https://github.com/goharbor/harbor/wiki#roadmap). - When reviewed and approved it can be implemented either by the original submitter which we highly encourage, as the project is community driven. That can happen via opening PRs in the respective repositories with all the necessary code and test changes! - Once implemented the PRs must be reviewed by maintainers and contributors prior merging following the currently enabled practices and methods. - After merging the new PRs the proposal must be moved to [community/proposals](https://github.com/goharbor/community/tree/main/proposals) and marked as Done! From 2f6ed453ff8ae525febd791b53ef9096cf3997c2 Mon Sep 17 00:00:00 2001 From: Orlix Date: Tue, 21 Mar 2023 08:56:06 +0200 Subject: [PATCH 3/7] Update CONTRIBUTING.md --- CONTRIBUTING.md | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d9627111104..ecc5bc50808 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -364,19 +364,19 @@ The main location for the documentation is the [website repository](https://gith Documents are written with Markdown. See [Writing on GitHub](https://help.github.com/categories/writing-on-github/) for more details. -## Propose and design new features +## Develop and propose new features. +### The following simple process can be used to submit new features or changes to the existing code. -You can propose new designs for existing Harbor features or you can also design entirely new features by following few simple step process: -- Check the current proposals if your feature is not requested or worked on already. Check both [Issues](https://github.com/goharbor/harbor/issues) and [PRs](https://github.com/goharbor/harbor/pulls) in the main Harbor repository also in the [Community repository](https://github.com/goharbor/community). +- See if your feature is already being worked on. Check both the [Issues](https://github.com/goharbor/harbor/issues) and the [PRs](https://github.com/goharbor/harbor/pulls) in the main Harbor repository as well as the [Community repository](https://github.com/goharbor/community). - Submit(open PR) the new proposal at [community/proposals/new](https://github.com/goharbor/community/tree/main/proposals/new) using the already existing [template](https://github.com/goharbor/community/blob/main/proposals/TEMPLATE.md) -- Once submitted it must be labeled as "kind/proposal" - check examples [here](https://github.com/goharbor/community/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+label%3Akind%2Fproposal) -- Will be automatically added to the [Community Proposals Board](https://github.com/orgs/goharbor/projects/4?query=is%3Aopen+sort%3Aupdated-desc) -- Once in on the board it must be added to a [Community Meeting agenda](https://github.com/goharbor/community/wiki/Harbor-Community-Meetings) to be presented to maintainers and contributors.(also moved to the next phase on the board "Community Meeting Discussion") -- Next is to be reviewed and modified by maintainers and other contributors maintainers in a timely manner. This is necessary to ensure the overall architecture is consistent and to avoid duplicated work in the [Roadmap](https://github.com/goharbor/harbor/wiki#roadmap). -- When reviewed and approved it can be implemented either by the original submitter which we highly encourage, as the project is community driven. That can happen via opening PRs in the respective repositories with all the necessary code and test changes! -- Once implemented the PRs must be reviewed by maintainers and contributors prior merging following the currently enabled practices and methods. -- After merging the new PRs the proposal must be moved to [community/proposals](https://github.com/goharbor/community/tree/main/proposals) and marked as Done! -- Congratulations you have made Harbor even better! Thank you! +- The proposal must labeled as "kind/proposal" - check examples [here](https://github.com/goharbor/community/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+label%3Akind%2Fproposal) +- The proposal can be modified and adapted to meet the requirements from the community and other maintainers and contributors. The overall architecture needs to be consistent to avoid duplicate work in the [Roadmap](https://github.com/goharbor/harbor/wiki#roadmap). +- Proposal should be discussed at Community meeting [Community Meeting agenda](https://github.com/goharbor/community/wiki/Harbor-Community-Meetings) to be presented to maintainers and contributors. +- When reviewed and approved it can be implemented either by the original submitter or anyone else from the community. which we highly encourage, as the project is community driven. Open PRs in the respective repositories with all the necessary code and test changes as described in the current document. +- Once implemented or during the implementation, the PRs are reviewed by maintainers and contributors, following the currently enabled practices and methods. +- After merging the new PRs, the proposal must be moved to [community/proposals](https://github.com/goharbor/community/tree/main/proposals) and marked as done! +- You have made Harbor even better, congratulations. Thank you! + [community-meetings]: https://github.com/goharbor/community/blob/main/MEETING_SCHEDULE.md From 43302135cc7f1f851b3e8c800a5179f3fa42c797 Mon Sep 17 00:00:00 2001 From: Orlix Date: Fri, 24 Mar 2023 14:43:20 +0200 Subject: [PATCH 4/7] Update CONTRIBUTING.md Co-authored-by: Thomas Coudert Signed-off-by: Orlix --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ecc5bc50808..d599ca2fa8c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -369,7 +369,7 @@ Documents are written with Markdown. See [Writing on GitHub](https://help.github - See if your feature is already being worked on. Check both the [Issues](https://github.com/goharbor/harbor/issues) and the [PRs](https://github.com/goharbor/harbor/pulls) in the main Harbor repository as well as the [Community repository](https://github.com/goharbor/community). - Submit(open PR) the new proposal at [community/proposals/new](https://github.com/goharbor/community/tree/main/proposals/new) using the already existing [template](https://github.com/goharbor/community/blob/main/proposals/TEMPLATE.md) -- The proposal must labeled as "kind/proposal" - check examples [here](https://github.com/goharbor/community/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+label%3Akind%2Fproposal) +- The proposal must be labeled as "kind/proposal" - check examples [here](https://github.com/goharbor/community/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+label%3Akind%2Fproposal) - The proposal can be modified and adapted to meet the requirements from the community and other maintainers and contributors. The overall architecture needs to be consistent to avoid duplicate work in the [Roadmap](https://github.com/goharbor/harbor/wiki#roadmap). - Proposal should be discussed at Community meeting [Community Meeting agenda](https://github.com/goharbor/community/wiki/Harbor-Community-Meetings) to be presented to maintainers and contributors. - When reviewed and approved it can be implemented either by the original submitter or anyone else from the community. which we highly encourage, as the project is community driven. Open PRs in the respective repositories with all the necessary code and test changes as described in the current document. From b1a8099272cc99825e00d7c4545c2a6615444b39 Mon Sep 17 00:00:00 2001 From: Orlix Date: Fri, 24 Mar 2023 14:43:43 +0200 Subject: [PATCH 5/7] Update CONTRIBUTING.md Co-authored-by: Thomas Coudert Signed-off-by: Orlix --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d599ca2fa8c..1ced29416cc 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -370,7 +370,7 @@ Documents are written with Markdown. See [Writing on GitHub](https://help.github - See if your feature is already being worked on. Check both the [Issues](https://github.com/goharbor/harbor/issues) and the [PRs](https://github.com/goharbor/harbor/pulls) in the main Harbor repository as well as the [Community repository](https://github.com/goharbor/community). - Submit(open PR) the new proposal at [community/proposals/new](https://github.com/goharbor/community/tree/main/proposals/new) using the already existing [template](https://github.com/goharbor/community/blob/main/proposals/TEMPLATE.md) - The proposal must be labeled as "kind/proposal" - check examples [here](https://github.com/goharbor/community/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+label%3Akind%2Fproposal) -- The proposal can be modified and adapted to meet the requirements from the community and other maintainers and contributors. The overall architecture needs to be consistent to avoid duplicate work in the [Roadmap](https://github.com/goharbor/harbor/wiki#roadmap). +- The proposal can be modified and adapted to meet the requirements from the community, other maintainers and contributors. The overall architecture needs to be consistent to avoid duplicate work in the [Roadmap](https://github.com/goharbor/harbor/wiki#roadmap). - Proposal should be discussed at Community meeting [Community Meeting agenda](https://github.com/goharbor/community/wiki/Harbor-Community-Meetings) to be presented to maintainers and contributors. - When reviewed and approved it can be implemented either by the original submitter or anyone else from the community. which we highly encourage, as the project is community driven. Open PRs in the respective repositories with all the necessary code and test changes as described in the current document. - Once implemented or during the implementation, the PRs are reviewed by maintainers and contributors, following the currently enabled practices and methods. From f7893ace5ab83987cce8411917bc3b4c0663b4be Mon Sep 17 00:00:00 2001 From: Orlix Date: Fri, 24 Mar 2023 14:44:16 +0200 Subject: [PATCH 6/7] Update CONTRIBUTING.md Co-authored-by: Thomas Coudert Signed-off-by: Orlix --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1ced29416cc..9ef7020ef42 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -372,7 +372,7 @@ Documents are written with Markdown. See [Writing on GitHub](https://help.github - The proposal must be labeled as "kind/proposal" - check examples [here](https://github.com/goharbor/community/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+label%3Akind%2Fproposal) - The proposal can be modified and adapted to meet the requirements from the community, other maintainers and contributors. The overall architecture needs to be consistent to avoid duplicate work in the [Roadmap](https://github.com/goharbor/harbor/wiki#roadmap). - Proposal should be discussed at Community meeting [Community Meeting agenda](https://github.com/goharbor/community/wiki/Harbor-Community-Meetings) to be presented to maintainers and contributors. -- When reviewed and approved it can be implemented either by the original submitter or anyone else from the community. which we highly encourage, as the project is community driven. Open PRs in the respective repositories with all the necessary code and test changes as described in the current document. +- When reviewed and approved it can be implemented either by the original submitter or anyone else from the community which we highly encourage, as the project is community driven. Open PRs in the respective repositories with all the necessary code and test changes as described in the current document. - Once implemented or during the implementation, the PRs are reviewed by maintainers and contributors, following the currently enabled practices and methods. - After merging the new PRs, the proposal must be moved to [community/proposals](https://github.com/goharbor/community/tree/main/proposals) and marked as done! - You have made Harbor even better, congratulations. Thank you! From 32ad38866f42889aa4f227c31a40557793fe718e Mon Sep 17 00:00:00 2001 From: Orlix Date: Fri, 24 Mar 2023 14:49:21 +0200 Subject: [PATCH 7/7] Update CONTRIBUTING.md update --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 9ef7020ef42..52082fdb99e 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -373,7 +373,7 @@ Documents are written with Markdown. See [Writing on GitHub](https://help.github - The proposal can be modified and adapted to meet the requirements from the community, other maintainers and contributors. The overall architecture needs to be consistent to avoid duplicate work in the [Roadmap](https://github.com/goharbor/harbor/wiki#roadmap). - Proposal should be discussed at Community meeting [Community Meeting agenda](https://github.com/goharbor/community/wiki/Harbor-Community-Meetings) to be presented to maintainers and contributors. - When reviewed and approved it can be implemented either by the original submitter or anyone else from the community which we highly encourage, as the project is community driven. Open PRs in the respective repositories with all the necessary code and test changes as described in the current document. -- Once implemented or during the implementation, the PRs are reviewed by maintainers and contributors, following the currently enabled practices and methods. +- Once implemented or during the implementation, the PRs are reviewed by maintainers and contributors, following the best practices and methods. - After merging the new PRs, the proposal must be moved to [community/proposals](https://github.com/goharbor/community/tree/main/proposals) and marked as done! - You have made Harbor even better, congratulations. Thank you!