-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls: evaluate hex/binary integer literals when mousing over #45802
Comments
I'd like to work on this cc: @stamblerre |
@danishprakash: Sounds good! Let me know if you need any guidance. |
@stamblerre I tried dabbling with this and have pushed my changes here https://github.com/golang/tools/compare/master...danishprakash:hover-evaluate-hex?expand=1. Let me know if that approach sounds good, I'll raise a pull request. |
Thanks for working on that @danishprakash! It does look like the right approach so feel free to send a PR. |
Posting the PR link here https://go-review.googlesource.com/c/tools/+/330309, not sure if the bot would backlink this. (ideally we should) |
Change https://golang.org/cl/330309 mentions this issue: |
What version of Go are you using (
go version
)?What did you do?
Mouse over a hex/binary notation integer
What did you expect to see?
Gopls evaluate the number in decimal form and show me the result (I'm in VSCode). Gopls does this for
const
identifiers and it is super helpful!What did you see instead?
Nothing
The text was updated successfully, but these errors were encountered: