Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: support authenticated proxies #587

Closed
ajstarks opened this issue Aug 30, 2018 · 8 comments
Closed

proxy: support authenticated proxies #587

ajstarks opened this issue Aug 30, 2018 · 8 comments
Labels
enhancement New feature or request proxy Work to do on the module proxy

Comments

@ajstarks
Copy link

ajstarks commented Aug 30, 2018

Note that this issue is probably related to #310, some environments have all outside Internet access mediated by an NTLM authenticated proxy. Athens should support this use-case

@ghost ghost added enhancement New feature or request proxy Work to do on the module proxy labels Aug 30, 2018
@timraymond
Copy link

I did a little research here since I had never heard of NTLM before :) The exchange that needs to happen between go, the proxy, and the outside world needs to look like this in an NTLM-authenticated world:

ic871898

I pulled the above from MSDN, and there's quite a bit of detail there.

One challenge here will be setting up a minimum-viable NTLM proxy + Active Directory-equivalent to develop against. I found this project which may be able to help with the proxy part. @ajstarks are you aware of any other alternatives which might help with developing this?

The other challenge is going to be getting go to do this exchange. One possible idea would be to shim go's upstream connection with a local http proxy (via the http_proxy ENV?) that performs this exchange with the bastion proxy.

@ajstarks
Copy link
Author

Yes, I know about cntlm but I have never used it. By the way, curl lets you do this:

curl --proxy [host:port] --proxy-ntlm -U[user:password]

The ideal case is for Athena to support this internally without other tools, of course

@ajstarks ajstarks changed the title proxy: support NTLM authentication proxy: support authenticated proxies Nov 30, 2018
@arschles
Copy link
Member

arschles commented Aug 5, 2019

@ajstarks did you figure out a way around this?

@ajstarks
Copy link
Author

ajstarks commented Aug 5, 2019

Sorry, no.

@ajstarks ajstarks reopened this Aug 5, 2019
@arschles
Copy link
Member

Just dropping a quick note in here - we haven't forgotten about this issue, but not planning to implement it at the moment. @ajstarks or anyone else interested - can you please 👍 this comment, or add your own comment if you need this functionality for your production Athens deployments?

@ajstarks
Copy link
Author

I currently don't need this now, so I'm ok with lowering the priority.

@arschles
Copy link
Member

@ajstarks I am going to close this, since you don't need it now. If it comes back up, comment here and I'll get the notification and come open the issue back up.

@arschles
Copy link
Member

just going to throw this in here: https://github.com/genotrance/px

This could potentially be a good way for Athens to download from VCS's via HTTP, and from upstream proxyes (which already use HTTP as we know)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request proxy Work to do on the module proxy
Projects
None yet
Development

No branches or pull requests

3 participants