Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

draco: Mostly CMake updates. #533

Merged
merged 3 commits into from
Jun 24, 2019
Merged

draco: Mostly CMake updates. #533

merged 3 commits into from
Jun 24, 2019

Conversation

tomfinegan
Copy link
Contributor

Commits:

1. Add CMake and clang format configuration files.
2. draco cmake: Run cmake-format on all CMake files.
3. draco cmake: Improve Android NDK toolchain support and fix a bug.
   - Move common NDK settings into cmake/toolchains/android-ndk-common.cmake.
   - Fix bug in set_variable_if_unset(). Was ignoring variables set via
     CMake's command line.

Fixes #475

@tomfinegan
Add CMake and clang format configuration files.
d8cf1e5
@tomfinegan
draco cmake: Run cmake-format on all CMake files.
5a99911
@tomfinegan
draco cmake: Improve Android NDK toolchain support and fix a bug.
fdaa47c 
- Move common NDK settings into cmake/toolchains/android-ndk-common.cmake.
- Fix bug in set_variable_if_unset(). Was ignoring variables set via
  CMake's command line.

Fixes #475.
@tomfinegan tomfinegan mentioned this pull request Jun 21, 2019
Closed
@tomfinegan tomfinegan merged commit c1255f6 into master Jun 24, 2019
@tomfinegan tomfinegan deleted the draco_misc branch December 8, 2020 20:38
danielgronlund pushed a commit to danielgronlund/draco that referenced this pull request Aug 22, 2024
@tomfinegan
Merge pull request google#533 from google/draco_misc
a8488b6 
draco: Mostly CMake updates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankGalligan FrankGalligan FrankGalligan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMake configure fails with c++_static.props not found
2 participants
@tomfinegan @FrankGalligan