Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py no longer works with source from PyPI #500

Closed
xylar opened this issue Jun 30, 2024 · 7 comments
Closed

setup.py no longer works with source from PyPI #500

xylar opened this issue Jun 30, 2024 · 7 comments

Comments

@xylar
Copy link

xylar commented Jun 30, 2024

Modifications made in 2024-07-01 to python/setup.py are no longer compatible with the source code uploaded to PyPI (https://files.pythonhosted.org/packages/b9/7c/6a44a14375496d0931ce349b580686ed3ed15bf0c62d77ae1a3a57fab110/google_re2-1.1.20240701.tar.gz)

This results in:

  Running command python setup.py egg_info
  Traceback (most recent call last):
    File "<string>", line 2, in <module>
    File "<pip-setuptools-caller>", line 34, in <module>
    File "/home/conda/feedstock_root/build_artifacts/google-re2_1719767281588/work/setup.py", line 111, in <module>
      os.makedirs(PACKAGE)
    File "/home/conda/feedstock_root/build_artifacts/google-re2_1719767281588/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.10/os.py", line 225, in makedirs
      mkdir(name, mode)
  FileExistsError: [Errno 17] File exists: 're2'
  error: subprocess-exited-with-error

because the processing that setup.py is trying to do has already been done for the source code on PyPI. Presumably, a process is needed to detect this and skip these modifications if they have already been made.

See the conda-forge build for more details:
conda-forge/google-re2-feedstock#14
Specifically the Azure-Pipelines output:
https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=966161&view=logs&jobId=d0d954b5-f111-5dc4-4d76-03b6c9d0cf7e&j=d0d954b5-f111-5dc4-4d76-03b6c9d0cf7e&t=6d4b912b-175d-51da-0fd9-4d30fe1eb4e7

@junyer
Copy link
Contributor

junyer commented Jun 30, 2024

Yikes! Thanks for the report!

@junyer
Copy link
Contributor

junyer commented Jun 30, 2024

I have a fix out for review. I should be able to cut release 2024-07-02 tomorrow night.

@xylar
Copy link
Author

xylar commented Jul 1, 2024

@junyer, thanks so much for responding so quickly!

@junyer
Copy link
Contributor

junyer commented Jul 1, 2024

You're welcome. :)

@junyer
Copy link
Contributor

junyer commented Jul 1, 2024

Keeping this issue open until the release is cut...

@junyer junyer reopened this Jul 1, 2024
@junyer
Copy link
Contributor

junyer commented Jul 1, 2024

Okay, release 2024-07-02 has been cut and, more to the point, published to PyPI. :)

@junyer junyer closed this as completed Jul 1, 2024
@xylar
Copy link
Author

xylar commented Jul 1, 2024

Wonderful, thank you, @junyer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants