-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setup.py
no longer works with source from PyPI
#500
Comments
Yikes! Thanks for the report! |
I have a fix out for review. I should be able to cut release |
@junyer, thanks so much for responding so quickly! |
You're welcome. :) |
Keeping this issue open until the release is cut... |
Okay, release |
Wonderful, thank you, @junyer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Modifications made in 2024-07-01 to
python/setup.py
are no longer compatible with the source code uploaded to PyPI (https://files.pythonhosted.org/packages/b9/7c/6a44a14375496d0931ce349b580686ed3ed15bf0c62d77ae1a3a57fab110/google_re2-1.1.20240701.tar.gz)This results in:
because the processing that
setup.py
is trying to do has already been done for the source code on PyPI. Presumably, a process is needed to detect this and skip these modifications if they have already been made.See the conda-forge build for more details:
conda-forge/google-re2-feedstock#14
Specifically the Azure-Pipelines output:
https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=966161&view=logs&jobId=d0d954b5-f111-5dc4-4d76-03b6c9d0cf7e&j=d0d954b5-f111-5dc4-4d76-03b6c9d0cf7e&t=6d4b912b-175d-51da-0fd9-4d30fe1eb4e7
The text was updated successfully, but these errors were encountered: