Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Request#parseNetworkResponse javadoc to disallow returning null #322

Open
jpd236 opened this issue Feb 26, 2020 · 1 comment
Open
Milestone

Comments

@jpd236
Copy link
Collaborator

jpd236 commented Feb 26, 2020

Request#parseNetworkResponse claims it's okay to return null if a response can't be parsed. In reality, it seems like this would almost guarantee an NPE either in CacheDispatcher or ExecutorDelivery, so unless someone has an entirely custom ResponseDelivery, they probably already are returning Response.error rather than null. We should verify this and consider updating the Javadoc accordingly.

@uhager
Copy link
Contributor

uhager commented Feb 26, 2020

To add to this, if someone uses a ResponseDelivery that does not call ExecutorDelivery, they also have to implement their own RequestQueue, since both Request#finish and RequestQueue#finish are package-private, and are the only way of removing the request from the RequestQueue's current requests.

@jpd236 jpd236 modified the milestones: 1.2.0, 1.2.1 Feb 15, 2021
@jpd236 jpd236 modified the milestones: 1.2.1, 1.2.2 Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants