Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Move Base AuthClient Types to authclient.ts #1773

Open
danielbankhead opened this issue Mar 12, 2024 · 2 comments · May be fixed by #1774
Open

refactor!: Move Base AuthClient Types to authclient.ts #1773

danielbankhead opened this issue Mar 12, 2024 · 2 comments · May be fixed by #1774
Assignees
Labels
Breaking Change good first issue This issue is a good place to started contributing to this repository. next major: breaking change this is a change that we should wait to bundle into the next major version priority: p3 Desirable enhancement or fix. May not be included in next release. semver: major Hint for users that this is an API breaking change. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@danielbankhead
Copy link
Member

Today, there are types imported from other AuthClients that should be in the base client's file. E.g.:

import {GetAccessTokenResponse, Headers} from './oauth2client';

These should be moved here and the imports should be updated throughout the codebase accordingly.

Implementation Notes:

  • Ensure any top-level exports in src/index.ts work seamlessly
@danielbankhead danielbankhead added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. semver: major Hint for users that this is an API breaking change. good first issue This issue is a good place to started contributing to this repository. Breaking Change priority: p3 Desirable enhancement or fix. May not be included in next release. next major: breaking change this is a change that we should wait to bundle into the next major version labels Mar 12, 2024
@HubertJan
Copy link

Hi @danielbankhead, I'd like to work on that.

Which other types should be moved to authclient.ts? At the moment, only GetAccessTokenResponse and Headers are directly imported from oauth2client.

@danielbankhead
Copy link
Member Author

Thanks!

At the moment, only GetAccessTokenResponse and Headers are directly imported from oauth2client.

Today, only those two types should be moved. As this functionality will not be released until the next major release, it's left intentionally open in case a type slips through in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change good first issue This issue is a good place to started contributing to this repository. next major: breaking change this is a change that we should wait to bundle into the next major version priority: p3 Desirable enhancement or fix. May not be included in next release. semver: major Hint for users that this is an API breaking change. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants