Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add optional projectId override in service object #722

Merged
merged 3 commits into from
Jan 18, 2022
Merged

feat: add optional projectId override in service object #722

merged 3 commits into from
Jan 18, 2022

Conversation

steffnay
Copy link
Contributor

@steffnay steffnay commented Jan 18, 2022 •
edited
Loading

This will allow libraries like nodejs-bigquery to implement cross-project support.

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

🦕

@steffnay steffnay marked this pull request as ready for review January 18, 2022 05:54
@steffnay steffnay requested a review from a team as a code owner January 18, 2022 05:54
@steffnay steffnay added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 18, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 18, 2022
@steffnay steffnay requested a review from bcoe January 18, 2022 15:14
@steffnay steffnay mentioned this pull request Jan 18, 2022
Closed
@steffnay steffnay merged commit 4908d85 into googleapis:main Jan 18, 2022
@release-please release-please bot mentioned this pull request Jan 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steffnay @bcoe