diff --git a/CHANGELOG.md b/CHANGELOG.md index 321c39911..8e383fc98 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,14 @@ [1]: https://www.npmjs.com/package/release-please?activeTab=versions +## [15.11.1](https://github.com/googleapis/release-please/compare/v15.11.0...v15.11.1) (2023-07-10) + + +### Bug Fixes + +* **deps:** Update dependency conventional-commits-filter to v3 ([#1976](https://github.com/googleapis/release-please/issues/1976)) ([20b8f34](https://github.com/googleapis/release-please/commit/20b8f345624f2a7e639df1a50ebda2719f9c2423)) +* **python:** Warn on dynamic pyproject.toml versioning ([#1983](https://github.com/googleapis/release-please/issues/1983)) ([5ee5baa](https://github.com/googleapis/release-please/commit/5ee5baa0932d3435034b96183fed308eaf47ef73)) + ## [15.11.0](https://github.com/googleapis/release-please/compare/v15.10.5...v15.11.0) (2023-05-31) diff --git a/package-lock.json b/package-lock.json index 9975eb2a3..8c89879ba 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "release-please", - "version": "15.11.0", + "version": "15.11.1", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "release-please", - "version": "15.11.0", + "version": "15.11.1", "license": "Apache-2.0", "dependencies": { "@conventional-commits/parser": "^0.4.1", diff --git a/package.json b/package.json index 1ee2d4851..7c4129196 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "release-please", - "version": "15.11.0", + "version": "15.11.1", "description": "generate release PRs based on the conventionalcommits.org spec", "main": "./build/src/index.js", "bin": "./build/src/bin/release-please.js", diff --git a/src/updaters/python/pyproject-toml.ts b/src/updaters/python/pyproject-toml.ts index 06ae818ee..db1163fed 100644 --- a/src/updaters/python/pyproject-toml.ts +++ b/src/updaters/python/pyproject-toml.ts @@ -13,8 +13,8 @@ // limitations under the License. import * as TOML from '@iarna/toml'; -import {replaceTomlValue} from '../../util/toml-edit'; import {logger as defaultLogger, Logger} from '../../util/logger'; +import {replaceTomlValue} from '../../util/toml-edit'; import {DefaultUpdater} from '../default'; // TODO: remove support for `poetry.tool` when Poetry will use `project`. @@ -22,6 +22,7 @@ import {DefaultUpdater} from '../default'; interface PyProjectContent { name: string; version: string; + dynamic?: string[]; } /** @@ -52,6 +53,14 @@ export class PyProjectToml extends DefaultUpdater { const project = parsed.project || parsed.tool?.poetry; if (!project?.version) { + // Throw warning if the version is dynamically generated. + if (project?.dynamic && project.dynamic.includes('version')) { + const msg = + "dynamic version found in 'pyproject.toml'. Skipping update."; + logger.warn(msg); + return content; + } + const msg = 'invalid file'; logger.error(msg); throw new Error(msg);