Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gopass generate --clip not copying to clipboard #1844

Closed
silkeh opened this issue Mar 17, 2021 · 2 comments · Fixed by #1846
Closed

gopass generate --clip not copying to clipboard #1844

silkeh opened this issue Mar 17, 2021 · 2 comments · Fixed by #1846
Assignees
@dominikschulz
Labels
bug Defects
Milestone
1.12.3

Comments

@silkeh
Copy link
Contributor

silkeh commented Mar 17, 2021

Summary

The --clip option of the gopass generate command no longer works. Using git bisect I found that this regression was introduced by #1806.

Steps To Reproduce

Using a clean build from source (from 877c3d8 or later):

$ ./gopass generate -c -f temp/temp 24
✅ Password for entry "temp/temp" generated
Not printing secrets by default. Use 'gopass show temp/temp' to display the password

No password is copied to the clipboard.

Expected behavior

Using a clean build from source (from v1.12.1):

$ ./gopass generate -c -f temp/temp 24
✅ Password for entry "temp/temp" generated
✔ Copied temp/temp to clipboard. Will clear in 45 seconds.
Copied to clipboard

Environment

  • OS: Solus
  • OS version: Linux enterprise 5.11.6-174.current #1 SMP PREEMPT Thu Mar 11 17:53:06 UTC 2021 x86_64 GNU/Linux
  • gopass Version: 1.12.2, 877c3d8, master
  • Installation method: from source
@dominikschulz
Copy link
Member

This looks suspicious.

@dominikschulz dominikschulz self-assigned this Mar 17, 2021
@dominikschulz dominikschulz added the bug Defects label Mar 17, 2021
@dominikschulz dominikschulz added this to the 1.12.3 milestone Mar 17, 2021
dominikschulz added a commit to dominikschulz/gopass that referenced this issue Mar 17, 2021
@dominikschulz
Fix generate --clip
2911b0a 
This was broken in a refactoring.

Fixes gopasspw#1844

RELEASE_NOTES=[BUGFIX] Fix generate -c

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz dominikschulz mentioned this issue Mar 17, 2021
Merged
@dominikschulz
Copy link
Member

Thanks for using bisect to find the culprit commit. That helped a lot!

dominikschulz added a commit that referenced this issue Mar 18, 2021
@dominikschulz
Fix generate --clip (#1846)
3157d29 
This was broken in a refactoring.

Fixes #1844

RELEASE_NOTES=[BUGFIX] Fix generate -c

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
kpitt pushed a commit to kpitt/gopass that referenced this issue Jul 21, 2022
@dominikschulz
Fix generate --clip (gopasspw#1846)
6b82ebf 
This was broken in a refactoring.

Fixes gopasspw#1844

RELEASE_NOTES=[BUGFIX] Fix generate -c

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dominikschulz dominikschulz

Labels
bug Defects
Projects
None yet
Milestone
1.12.3
Development

Successfully merging a pull request may close this issue.

Fix generate --clip dominikschulz/gopass
2 participants
@dominikschulz @silkeh