Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix video and photo entrypoints and bump version #69

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Fix video and photo entrypoints and bump version #69

merged 1 commit into from
Sep 28, 2021

Conversation

tcamise-gpsw
Copy link
Collaborator

@tcamise-gpsw tcamise-gpsw commented Sep 28, 2021 •
edited
Loading

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Does this pull request reference an issue (i.e. bug or enhancement)? If not, you should probably create one. If it is a very simple / small change, this is not needed and just describe the issue below.
  • Make sure to link this pull request to the issue after the pull request is created.
  • Anyone can review this but make sure to add at least one administrator (anyone who can be found under Reviewers)
  • Make sure to add necessary documentation (if appropriate)
  • Once the pull request is created, ensure that the pre-merge checks all run succesfully.
  • If you add a file that requires copyright updates, this will be automatically done via pre-merge checks and pushed to your branch.

Description

Photo and Video entrypoints in Python SDK were not parsing the input parameters.

@tcamise-gpsw tcamise-gpsw linked an issue Sep 28, 2021 that may be closed by this pull request
Error launching photo/video demo #68
Closed
@tcamise-gpsw tcamise-gpsw merged commit d6333f6 into main Sep 28, 2021
@tcamise-gpsw tcamise-gpsw deleted the fix_python_sdk_entrypoints branch September 28, 2021 22:41
tcamise-gpsw pushed a commit that referenced this pull request Nov 4, 2021
Hotfixes: (1) Fixed bug where some setting options were renamed as "M… (
7118142 
#69)

* Hotfixes: (1) Fixed bug where some setting options were renamed as "Maximum Video Performance", (2) Fixed bug where some "Presets: Load - XXX" were being documented more than once, (3) Sort commands first by command ID/title and then by ble-request/http-endpoint so it's not so random looking

* Added minimum firmware version to protobuf commands table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error launching photo/video demo
1 participant
@tcamise-gpsw