Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change subsystem names to remove confusion #722

Closed
rfratto opened this issue Jul 7, 2021 · 1 comment · Fixed by #940
Closed

Change subsystem names to remove confusion #722

rfratto opened this issue Jul 7, 2021 · 1 comment · Fixed by #940
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. keepalive Never close from staleness

Comments

@rfratto
Copy link
Member

rfratto commented Jul 7, 2021 •
edited
Loading

Naming the subsystems of the Agent prometheus, loki, and tempo was well-intentioned but mostly confusing. We should rename them as following:

  • Change prometheus to metrics
  • Change loki to logs
  • Change tempo to traces

For backwards compatibility, both names should be supported in the config file, but the old names should be marked as deprecated so we can remove them in a future release.
@rfratto rfratto added the keepalive Never close from staleness label Jul 7, 2021
@rfratto rfratto changed the title Change subsystem names to remove confusion. Change subsystem names to remove confusion Jul 7, 2021
@rfratto
Copy link
Member Author

rfratto commented Jul 7, 2021

This change should also be made in the Grafana Agent Operator, with the same backwards compatibility (ie support both PrometheusInstance and MetricsInstance).

@rfratto rfratto mentioned this issue Jul 8, 2021
Merged
3 tasks
This was referenced Aug 23, 2021
Merged
Merged
@rfratto rfratto mentioned this issue Sep 2, 2021
Merged
3 tasks
@rfratto rfratto mentioned this issue Sep 9, 2021
Merged
@mattdurham mattdurham mentioned this issue Sep 13, 2021
Merged
3 tasks
@rfratto rfratto mentioned this issue Sep 27, 2021
Merged
3 tasks
@mapno mapno mentioned this issue Oct 14, 2021
Merged
3 tasks
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. keepalive Never close from staleness
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename Prometheus to Metrics in docs / jsonnet rfratto/agent
1 participant
@rfratto