Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work with upstream to make node_exporter integration easier to maintain #548

Open
rfratto opened this issue Jan 6, 2022 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@rfratto
Copy link
Member

rfratto commented Jan 6, 2022

grafana/agent#1228 updated our dependency on node_exporter from v1.0.1 to v1.3.1. This ended up being a lot more work than I thought it would be, primarily due to its mapping of YAML to the global kingpin flags node_exporter creates.

It will be easier (and less error prone) to maintain the node_exporter integration in the future if we work with upstream to make the integration easier to maintain. I haven't put a ton of thought into it, but I think this at least removing the usage of unexported globals that configure collectors.

@marctc
Copy link
Contributor

marctc commented Oct 9, 2023

WIP PR: prometheus/node_exporter#2812

@rfratto rfratto added the enhancement New feature or request label Apr 9, 2024
@rfratto rfratto transferred this issue from grafana/agent Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: In Progress
Development

No branches or pull requests

2 participants