Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tempo] Improve vision on dropped spans #555

Open
joe-elliott opened this issue Aug 16, 2021 · 1 comment
Open

[Tempo] Improve vision on dropped spans #555

joe-elliott opened this issue Aug 16, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@joe-elliott
Copy link
Member

Currently observability on dropped spans is poor. The agent is based on the OTEL collector which has this issue:

open-telemetry/opentelemetry-collector#2434

Additionally if batches are dropped b/c the queue is full they go unmetriced. This is logged, but not metriced as a failed send: "Dropping data because sending_queue is full"

https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/monitoring.md#secondary-monitoring

Let's keep an eye on these issues and revendor when they are fixed. If we have spare cycles these are also good issues for upstream contributions.

@stale
Copy link

stale bot commented Sep 19, 2021

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@rfratto rfratto added the enhancement New feature or request label Apr 9, 2024
@rfratto rfratto transferred this issue from grafana/agent Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: No status
Development

No branches or pull requests

2 participants